Unemployment fell during the war entirely because of the buildup of the armed forces. In 1940, some 4.62 million persons were actually unemployed (the official count of 7.45 million included 2.83 million employed on various government work projects). During the war, the government, by conscription for the most part, drew some 16 million persons into the armed forces at some time; the active-duty force in mid-1945 numbered in excess of 12 million. Voila, civilian unemployment nearly disappeared. But herding the equivalent of 22 percent of the prewar labor force into the armed forces (to eliminate 9.5 percent unemployment) scarcely produced what we are properly entitled to call prosperity.
Yes, officially measured GDP soared during the war. Examination of that increased output shows, however, that it consisted entirely of military goods and services. Real civilian consumption and private investment both fell after 1941, and they did not recover fully until 1946. The privately owned capital stock actually shrank during the war. Some prosperity. (My article in the peer-reviewed Journal of Economic History, March 1992, presents many of the relevant details.)
It is high time that we come to appreciate the distinction between the government spending, especially the war spending, that bulks up official GDP figures and the kinds of production that create genuine economic prosperity. As Ludwig von Mises wrote in the aftermath of World War I, “war prosperity is like the prosperity that an earthquake or a plague brings.”
That’s from the economist Robert Higgs who debunks the popular myth.
Common sense tells us that it would be foolish to ever think that society prospers from death and destruction, despite what statistics say. Yet many fall for sloppy generalizations, which has been founded on the post hoc fallacy and the broken window "war prosperity" myth.
Again Professor Art Carden on the Broken Window Fallacy